Narrow dotted block argument diagnostics - #1311
Merged
Merged
Conversation
charlespwd
marked this pull request as ready for review
September 30, 2026 12:24
karreiro
approved these changes
Sep 30, 2026
karreiro
left a comment
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @charlespwd!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Narrow the
LiquidSyntaxErrordiagnostic for unsupported dottedblockarguments to the first offending argument.Problem
Theme Check correctly rejects caller arguments such as
block.settings.heading: value, but it reports the fullLiquidTagrange. For a body-form invocation, the editor underlines the opening tag, all inline children, and the closing tag instead of the syntax that needs to change.Solution
The block syntax check now locates the message and range together. Unsupported dotted arguments use the first invalid argument's range. Other block syntax errors keep their existing full-tag ranges.
blockTagSyntaxError()keeps its current signature and rule ordering, so the other block parameter checks still suppress cascading diagnostics and each malformed tag still produces one syntax error.This includes a patch changeset for
@shopify/theme-check-common.